Bugfix/media upload failed on all hosts#2240
Merged
DavidsonGomes merged 11 commits intoEvolutionAPI:developfrom Dec 5, 2025
Merged
Bugfix/media upload failed on all hosts#2240DavidsonGomes merged 11 commits intoEvolutionAPI:developfrom
DavidsonGomes merged 11 commits intoEvolutionAPI:developfrom
Conversation
Contributor
|
🧙 Sourcery has finished reviewing your pull request! Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
![sourcery-ai[bot]](https://avatars.githubusercontent.com/in/48477?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Hey there - I've reviewed your changes - here's some feedback:
- Consider refactoring the duplicated protocol constants and agent‐selection switch logic into a shared helper to avoid code duplication between makeProxyAgent and makeProxyAgentUndici.
- selectProxyAgent adds socks5 support but doesn’t handle socks4 protocol—add PROXY_SOCKS4_PROTOCOL and a case for it for consistency with makeProxyAgentUndici.
Prompt for AI Agents
Please address the comments from this code review:
## Overall Comments
- Consider refactoring the duplicated protocol constants and agent‐selection switch logic into a shared helper to avoid code duplication between makeProxyAgent and makeProxyAgentUndici.
- selectProxyAgent adds socks5 support but doesn’t handle socks4 protocol—add PROXY_SOCKS4_PROTOCOL and a case for it for consistency with makeProxyAgentUndici.Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
Collaborator
|
Please fix the conflicts, OK? |
…oad-failed-on-all-hosts # Conflicts: # package-lock.json # src/utils/makeProxyAgent.ts
Contributor
Author
@DavidsonGomes Conflitos resolvidos, agora as proxies do tipo socks devem funcionar corretamente! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
📋 Description
Correção no uso de proxy socks dentro do axios
🔗 Related Issue
Closes #(issue_number)
🧪 Type of Change
🧪 Testing
📸 Screenshots (if applicable)
✅ Checklist
📝 Additional Notes